Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse memory slots #2188

Merged
merged 5 commits into from
Oct 10, 2020
Merged

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Allow for releasing and reuse of memory slots.

How I did it

  • Within the memory allocator, add a method release_memory that accepts an offset and length. Released memory is tracked in a a list using FreeMemory objects. These objects are essentially 2 item lists, but I think the special class makes the code more readable.
  • Calls to increase_memory check for available slots in released memory, and if found they are reused instead of expanding memory.
  • Upon exiting the make_blockscope context manager, all memory variables that are no longer accessible are released.
  • Added a new context manager internal_memory_scope. It works identically to make_blockscope. I added it to differentiate between an actual user-defined scope (for loop, if branches) and an internal scope (event generation, assertions). I applied it to several areas where we generate temporary memory variables.

How to verify it

Run the tests. I haven't added any specific cases around this, but it should factor into the majority of the test suite. I verified the behavior by compiling and running the tests at https://github.com/curvefi/curve-contract and everything works.

Cute Animal Picture

image

@fubuloubu fubuloubu merged commit 7f2c969 into vyperlang:master Oct 10, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-memory-release branch October 15, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants