Merge Context.get_placeholder
and Context.get_internal_variable
#2194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Merge
Context.get_placeholder
andContext.get_internal_variable
How I did it
Both of these methods served an identical purpose and
get_internal_variable
was only used twice in the codebase. I've merged the logic into a single function and added docstrings to make it more clear what is happening.How to verify it
Run tests.
Cute Animal Picture