Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Validate address checksums during AST generation.
Closes #2216
How I did it
Since we only use
Hex
foraddress
andbytes32
, I've moved the checksum validation intoHex.validate
. This is the earliest point we can catch the issue, and ensures it can't be missed in one of several spots within type checking.How to verify it
Run the tests. I've added some cases to verify this.
Cute Animal Picture