fix: convert bytes to hex when generating ast dict #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
fix-bytes-ast
branch
from
cf8a1bb
to
9bc71c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2231 +/- ##
=======================================
Coverage 85.36% 85.37%
=======================================
Files 84 84
Lines 8544 8545 +1
Branches 2065 2065
=======================================
+ Hits 7294 7295 +1
Misses 744 744
Partials 506 506
Continue to review full report at Codecov.
|
|
It's already covered in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Represent bytes as hex in the AST output. This fixes an issue where some bytestrings produce compilable code, but cannot be serialized as the AST dict.
Closes #2163
How I did it
See code, pretty self explanatory.
How to verify it
Run tests.
Cute Animal Picture