-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py39 configs and prepare to drop py36 #2233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 85.37% 85.40% +0.03%
==========================================
Files 84 84
Lines 8552 8552
Branches 2066 2066
==========================================
+ Hits 7301 7304 +3
+ Misses 745 743 -2
+ Partials 506 505 -1
Continue to review full report at Codecov.
|
Hi, and thanks your contribution! The requirement to install rust is related to ethereum/blake2b-py#2 - as soon as this is fixed upstream we plan to roll out official support for Python 3.9. The required code changes were handled in #2225 so I think this is the only remaining blocker. It might be better if you remove rust installation from the |
@iamdefinitelyahuman awesome, thanks for your quick response. I've pushed a new commit and updated the PR's description. :) |
Rebase on master Py 3.9 support was added to blake2s-py per v0.1.4, so update the pin for that package and this should be ready to merge! |
@fubuloubu rebased. ✔️ (cc @iamdefinitelyahuman) |
Hey.
This is my first PR here. 🎉
What I did
py39
in GitHub Actions;py36
bypy38
for all CI actions;black
to usepy38
.Why I didn't drop 3.6?
Well, I'm not sure if we really need to. My suggestion is to keep an isolated GitHub action for this version until it becomes obsolete.
How to verify it
Check GitHub Actions.
Why this build is 🔴?
Python 3.9 build is breaking due to davesque/blake2b-py installation.
We must wait ethereum/blake2b-py#2 to rebuild.
Related issue
#2182
Cute Animal Picture