Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py39 configs and prepare to drop py36 #2233

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

izn
Copy link
Contributor

@izn izn commented Nov 28, 2020

Hey.

This is my first PR here. 🎉

What I did

  1. Create a new action to run py39 in GitHub Actions;
  2. Replace py36 by py38 for all CI actions;
  3. Force black to use py38.

Why I didn't drop 3.6?

Well, I'm not sure if we really need to. My suggestion is to keep an isolated GitHub action for this version until it becomes obsolete.

How to verify it

Check GitHub Actions. :trollface:

Why this build is 🔴?

Python 3.9 build is breaking due to davesque/blake2b-py installation.

The requirement to install Rust is related to ethereum/blake2b-py#2 - as soon as this is fixed upstream we plan to roll out official support for Python 3.9.

We must wait ethereum/blake2b-py#2 to rebuild.

Related issue

#2182

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-io
Copy link

codecov-io commented Nov 28, 2020

Codecov Report

Merging #2233 (0d5c798) into master (a222091) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2233      +/-   ##
==========================================
+ Coverage   85.37%   85.40%   +0.03%     
==========================================
  Files          84       84              
  Lines        8552     8552              
  Branches     2066     2066              
==========================================
+ Hits         7301     7304       +3     
+ Misses        745      743       -2     
+ Partials      506      505       -1     
Impacted Files Coverage Δ
vyper/cli/vyper_json.py 85.20% <0.00%> (+0.40%) ⬆️
vyper/ast/validation.py 72.09% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a222091...b8d72d2. Read the comment docs.

@izn izn marked this pull request as ready for review November 28, 2020 13:09
@iamdefinitelyahuman
Copy link
Contributor

Hi, and thanks your contribution!

The requirement to install rust is related to ethereum/blake2b-py#2 - as soon as this is fixed upstream we plan to roll out official support for Python 3.9. The required code changes were handled in #2225 so I think this is the only remaining blocker.

It might be better if you remove rust installation from the py39-core job. When the upstream dep is dealt with, this PR should be able to pass CI without installing rust, and then it will be ready to merge.

@izn izn changed the title Add py39 configs and prepare to drop py36 [DO NOT MERGE] Add py39 configs and prepare to drop py36 Nov 28, 2020
@izn
Copy link
Contributor Author

izn commented Nov 28, 2020

@iamdefinitelyahuman awesome, thanks for your quick response. I've pushed a new commit and updated the PR's description. :)

@fubuloubu
Copy link
Member

Rebase on master

Py 3.9 support was added to blake2s-py per v0.1.4, so update the pin for that package and this should be ready to merge!

@izn izn changed the title [DO NOT MERGE] Add py39 configs and prepare to drop py36 Add py39 configs and prepare to drop py36 Mar 22, 2021
@izn
Copy link
Contributor Author

izn commented Mar 22, 2021

@fubuloubu rebased. ✔️ (cc @iamdefinitelyahuman)

@fubuloubu fubuloubu merged commit 3e1ff1e into vyperlang:master Mar 22, 2021
@izn izn deleted the add-py39-support branch March 23, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants