Allow empty
as an argument in a function call
#2234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allow use of
empty(Bytes[n])
as an argument within a function call.Closes #2112
How I did it
vyper.parser.parser_utils::pack_arguments
, add a branch of logic to handleempty
. Because empty implies a length of 0 bytes, the logic here is very simple: add 64 empty bytes from the end of calldata.b""
and""
. The overhead of the bytes copier is unnecessary in these situations.How to verify it
Run the tests. I added some cases.
Cute Animal Picture