Fixes for bytearrays as hashmap key #2239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix two compile-time issues related to bytearray types as
HashMap
keys:Closes #2237
How I did it
vyper/parser/parser_utils.py
, do not assume that the key is a memory offset. This allows the use of structs.vyper/parser/expr.py
, add a special case when the key is a bytearray in storage. Becausesha3
only works on memory, we must first copy the bytearray to memory.How to verify it
Run the tests. I've added several new cases to target this (and related) behavior.
Cute Animal Picture