Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider events during type-check "implements:" #2283

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

During type checking. consider events when validating the implements statement.

How I did it

Expand the existing code for implements - most of the logic is just ported over from how we check functions.

How to verify it

Verify the test suite is still passing. This is already very well tested so I have not added further cases.

Cute Animal Picture

image

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #2283 (ed763b2) into master (4ac9e49) will decrease coverage by 0.07%.
The diff coverage is 64.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
- Coverage   85.44%   85.37%   -0.08%     
==========================================
  Files          84       84              
  Lines        8591     8614      +23     
  Branches     2075     2083       +8     
==========================================
+ Hits         7341     7354      +13     
- Misses        748      756       +8     
- Partials      502      504       +2     
Impacted Files Coverage Δ
vyper/context/types/meta/event.py 75.47% <44.44%> (-7.14%) ⬇️
vyper/context/types/meta/interface.py 77.45% <70.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac9e49...cef75ae. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit f8782e0 into vyperlang:master Jan 24, 2021
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-implements-events branch January 24, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants