Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
Added some logic in
assembly_to_evm
withincompile_lll.py
Both of these situations occur as a result of LLL generation happening in small chunks that don't see the "bigger picture" around them. There is likely a more elegant solution here, but this is effective and simple to implement. I've left comments about what's happening, we can try to address this properly as we refactor out
parser
in the future and give ourselves more effective data structures to catch and fix this as it happens rather than after the fact.How to verify it
Run tests, confirm that nothing broke. If this created any issues we'd see tests failing everywhere, especially within the e2e tests of the examples.
Cute Animal Picture
Notice me senpai!