Optimize nonpayable assertion #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 980dd35 into b378bfd - view on LGTM.com new alerts:
|
iamdefinitelyahuman
force-pushed
the
feat-payable-check
branch
from
980dd35
to
8673de6
Compare
fubuloubu
approved these changes
Feb 16, 2021
iamdefinitelyahuman
force-pushed
the
feat-payable-check
branch
from
8673de6
to
c3be488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Optimize how the nonpayable check is applied within the bytecode
How I did it
Where possible, external functions are now organized by [payable], [nonpayable] and a single assertion that
msg.value == 0is placed in between the two sections.When a contract contains a payable default function, and nonpayable functions, this optimization is not possible and the check is still applied per-function.
How to verify it
Run the tests. I expanded the testing around the
@payabledecorator to handle all the different possible permutations based on this optimization.Cute Animal Picture