Fix: incorrect TypeMismatch
when dealing with literals in lists
#2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix an issue preventing literal lists where some members are literals and others are not. For example:
This would fail because in
parser/stmt.py
the literal2
is interpreted as anint128
. However, we know this to be incorrect because we have already completed the type checking pass.How I did it
Remove the now-redundant check that was blocking this at compile-time. I did some minor voodoo to retain the type information within
parser
so that nothing else breaks later down the line, and left a comment to prevent confusion later when we refactor types out altogether.How to verify it
Check that tests are passing.
Cute Animal Picture