Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotated kwargs for builtins #2389

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

charles-cooper
Copy link
Member

This is a regression in v0.2.14, the way function calls got annotated
was changed but kwargs didn't get the update.

Test case:

balances: HashMap[uint256, uint256]
@external
def foo(receiver: address):
  raw_call(receiver, b"", value=self.balance - self.balances[0])

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

This is a regression in v0.2.14, the way function calls got annotated
was changed but kwargs didn't get the update.

Test case:
```
balances: HashMap[uint256, uint256]
@external
def foo(receiver: address):
  raw_call(receiver, b"", value=self.balance - self.balances[0])
```
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #2389 (8c5755f) into master (db2606d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2389      +/-   ##
==========================================
- Coverage   85.84%   85.81%   -0.04%     
==========================================
  Files          91       91              
  Lines        9022     9024       +2     
  Branches     2152     2153       +1     
==========================================
- Hits         7745     7744       -1     
- Misses        785      787       +2     
- Partials      492      493       +1     
Impacted Files Coverage Δ
vyper/semantics/validation/annotation.py 94.96% <100.00%> (+0.07%) ⬆️
vyper/builtin_functions/functions.py 88.36% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2606d...8c5755f. Read the comment docs.

@charles-cooper charles-cooper marked this pull request as ready for review July 22, 2021 04:23
@charles-cooper
Copy link
Member Author

@fubuloubu test inbound

@charles-cooper
Copy link
Member Author

(got offline approval from @fubuloubu )

@charles-cooper charles-cooper merged commit fda6ee2 into vyperlang:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants