Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow interfaces in lists,structs,maps #2397

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jul 27, 2021

The dict of interfaces was not being passed around correctly during
parse_type, resulting in variables like the following not type-checking:

interface Foo:
  ...
foos: HashMap[..., Foo] # didn't type check

Fixes #1824

What I did

How I did it

How to verify it

Compile the above example

Description for the changelog

Allow interfaces in lists, structs and maps

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

The dict of interfaces was not being passed around correctly during
parse_type, resulting in variables like the following not type-checking:

interface Foo:
  ...
foos: HashMap[..., Foo] # doesn't type check

Fixes vyperlang#1824
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #2397 (6f13e2b) into master (cbc9e65) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   85.78%   85.73%   -0.06%     
==========================================
  Files          91       91              
  Lines        9024     9026       +2     
  Branches     2153     2154       +1     
==========================================
- Hits         7741     7738       -3     
- Misses        788      791       +3     
- Partials      495      497       +2     
Impacted Files Coverage Δ
vyper/old_codegen/types/types.py 81.09% <57.14%> (-0.82%) ⬇️
vyper/old_codegen/global_context.py 66.92% <100.00%> (ø)
vyper/builtin_functions/functions.py 88.36% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc9e65...6f13e2b. Read the comment docs.

@charles-cooper charles-cooper marked this pull request as ready for review July 27, 2021 22:54
@charles-cooper charles-cooper merged commit 0a389e3 into vyperlang:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow interfaces to be used in mappings
3 participants