refactor events #2403
Merged
refactor events #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2403 +/- ##
==========================================
- Coverage 85.73% 85.48% -0.25%
==========================================
Files 91 91
Lines 9101 9035 -66
Branches 2176 2151 -25
==========================================
- Hits 7803 7724 -79
- Misses 796 805 +9
- Partials 502 506 +4
Continue to review full report at Codecov.
|
|
This pull request introduces 3 alerts when merging 492587d into 0a389e3 - view on LGTM.com new alerts:
|
charles-cooper
force-pushed
the
events_refactor
branch
from
492587d
to
e9e568c
Compare
|
This pull request introduces 8 alerts when merging e9e568c into 0a389e3 - view on LGTM.com new alerts:
|
- use abi_encode for the data - use keccak256_helper for non-basetype topics - block non-value types in indexes note: a test for blocked functionality has been removed because the functionality now works
charles-cooper
force-pushed
the
events_refactor
branch
from
e9e568c
to
52ac67a
Compare
charles-cooper
force-pushed
the
events_refactor
branch
from
c777653
to
be42f18
Compare
The key is to make sure the memory is allocated and registered with the context variable BEFORE evaluating the expressions inside the event (in case any of them make internal calls) fixes vyperlang#1476
charles-cooper
force-pushed
the
events_refactor
branch
from
be42f18
to
cea5dd8
Compare
fubuloubu
approved these changes
Aug 5, 2021
I removed those because arrays are now blocked from being event indexes. |
iamdefinitelyahuman
approved these changes
Aug 6, 2021
charles-cooper
commented
Aug 6, 2021
| if typ.is_dynamic_size: | ||
| maxlen += typ.size_in_bytes | ||
| # sanity check, abi size_bound is the same calculated both ways | ||
| print(data.typ, type(data.typ)) |
There was a problem hiding this comment.
oh haha i left this in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
refactor events to use abi_encode. Fixes #1170, #1476
note: a test for blocked functionality has been removed because the functionality now works
How I did it
How to verify it
Description for the changelog
Cute Animal Picture