-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(install): add new install method via nix #2405
Conversation
update install directions to include `nix` pkg of vyper. fix minor spelling errors
Codecov Report
@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
- Coverage 85.73% 85.48% -0.25%
==========================================
Files 91 91
Lines 9026 9030 +4
Branches 2154 2152 -2
==========================================
- Hits 7738 7719 -19
- Misses 791 806 +15
- Partials 497 505 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sambacha thanks, looking pretty good, I left some comments - main thing is I think we can skip everything that is covered by the nixos package search since we are already linking to it.
structured the nix section to address PR comments, additionally added a link directly to the dockerhub for vyper.
4914f1a
to
1331759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! LGTM
What I did
nix
How I did it
Edited the page.
How to verify it
I installed vyper 0.2.11 via nix on my laptop and compiled a contract successfully.
Description for the changelog
Cute Animal Picture
No