Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes struct example #2425

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fixes struct example #2425

merged 1 commit into from
Aug 17, 2021

Conversation

milancermak
Copy link
Contributor

What I did

As mentioned #2422, the struct example in the docs is slightly wrong. Here's the fix.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #2425 (07fef11) into master (ed59064) will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
- Coverage   85.47%   84.61%   -0.87%     
==========================================
  Files          91       91              
  Lines        9027     9027              
  Branches     2151     2151              
==========================================
- Hits         7716     7638      -78     
- Misses        806      882      +76     
- Partials      505      507       +2     
Impacted Files Coverage Δ
vyper/semantics/types/value/numeric.py 80.64% <0.00%> (-5.38%) ⬇️
vyper/builtin_functions/functions.py 83.53% <0.00%> (-4.93%) ⬇️
vyper/old_codegen/expr.py 75.52% <0.00%> (-4.59%) ⬇️
vyper/ast/nodes.py 92.12% <0.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed59064...07fef11. Read the comment docs.

@charles-cooper charles-cooper merged commit 7709f73 into vyperlang:master Aug 17, 2021
@milancermak milancermak deleted the patch-2 branch August 17, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants