disallow changes to decimal precision #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we have a test for it but apparently it hasn't been getting run |
charles-cooper
force-pushed
the
fix/decimal_truncation
branch
from
d2a6221
to
3ba5932
Compare
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
==========================================
- Coverage 84.53% 84.52% -0.02%
==========================================
Files 93 93
Lines 9223 9228 +5
Branches 2084 2085 +1
==========================================
+ Hits 7797 7800 +3
- Misses 938 939 +1
- Partials 488 489 +1
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 3ba5932 into c763d96 - view on LGTM.com new alerts:
|
fubuloubu
approved these changes
Oct 7, 2021
it is already set correctly in parser_utils.py. otherwise, literals like (-2**127 - 0.001) will silently have digits truncated.
charles-cooper
force-pushed
the
fix/decimal_truncation
branch
from
3ba5932
to
d97a355
Compare
charles-cooper
changed the title
fubuloubu
approved these changes
Oct 7, 2021
charles-cooper
force-pushed
the
fix/decimal_truncation
branch
from
1925bad
to
30709fd
Compare
charles-cooper
added a commit
to charles-cooper/brownie
that referenced
this pull request
Oct 24, 2021
vyperlang/vyper#2479 disabled changes to the global decimal context to preserve compile-time constant semantics. This commit changes use of the global getcontext to a local context. It shouldn't change the behavior of the current code (since it didn't depend on modifying the global context, just having a local Context with the correct precision).
4 tasks
charles-cooper
added a commit
to charles-cooper/brownie
that referenced
this pull request
Oct 27, 2021
vyperlang/vyper#2479 disabled changes to the global decimal context to preserve compile-time constant semantics. This commit changes use of the global getcontext to a local context. It shouldn't change the behavior of the current code (since it didn't depend on modifying the global context, just having a local Context with the correct precision).
charles-cooper
added a commit
to charles-cooper/brownie
that referenced
this pull request
Oct 27, 2021
vyperlang/vyper#2479 disabled changes to the global decimal context to preserve compile-time constant semantics. This commit changes use of the global getcontext to a local context. It shouldn't change the behavior of the current code (since it didn't depend on modifying the global context, just having a local Context with the correct precision).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise, literals like (-2**127 - 0.001) will silently have digits
truncated.
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture