Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkable raw_call #2482

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Oct 8, 2021

What I did

Implement #2400

How I did it

How to verify it

Check the tests!

Description for the changelog

Add revert_on_failure kwarg to raw_call to allow handling raw_call failure

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title [WIP] checkable raw_call WIP: checkable raw_call Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #2482 (d2e66f5) into master (9560c70) will increase coverage by 0.04%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
+ Coverage   84.56%   84.61%   +0.04%     
==========================================
  Files          93       94       +1     
  Lines        9228     9295      +67     
  Branches     2086     2097      +11     
==========================================
+ Hits         7804     7865      +61     
- Misses        937      943       +6     
  Partials      487      487              
Impacted Files Coverage Δ
vyper/old_codegen/parser_utils.py 82.78% <ø> (-0.28%) ⬇️
vyper/builtin_functions/functions.py 88.68% <91.30%> (-0.27%) ⬇️
vyper/old_codegen/arg_clamps.py 53.84% <0.00%> (-15.39%) ⬇️
vyper/evm/opcodes.py 100.00% <0.00%> (ø)
vyper/cli/vyper_lll.py 0.00% <0.00%> (ø)
vyper/lll/optimizer.py 84.07% <0.00%> (ø)
vyper/semantics/environment.py 100.00% <0.00%> (ø)
vyper/old_codegen/types/types.py 82.96% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9560c70...d2e66f5. Read the comment docs.

allow storing raw_call success instead of reverting.

TODO needs tests, and streamline the logic so it's less confusing
@charles-cooper charles-cooper changed the title WIP: checkable raw_call checkable raw_call Oct 24, 2021
@charles-cooper charles-cooper marked this pull request as ready for review October 24, 2021 18:11
@charles-cooper charles-cooper merged commit 317625f into vyperlang:master Oct 25, 2021
@charles-cooper charles-cooper deleted the checkable_raw_call branch October 25, 2021 19:11
fubuloubu added a commit that referenced this pull request Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants