-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkable raw_call #2482
Merged
charles-cooper
merged 6 commits into
vyperlang:master
from
charles-cooper:checkable_raw_call
Oct 25, 2021
Merged
checkable raw_call #2482
charles-cooper
merged 6 commits into
vyperlang:master
from
charles-cooper:checkable_raw_call
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
force-pushed
the
checkable_raw_call
branch
from
October 8, 2021 21:51
eeed200
to
4469aaa
Compare
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
==========================================
+ Coverage 84.56% 84.61% +0.04%
==========================================
Files 93 94 +1
Lines 9228 9295 +67
Branches 2086 2097 +11
==========================================
+ Hits 7804 7865 +61
- Misses 937 943 +6
Partials 487 487
Continue to review full report at Codecov.
|
allow storing raw_call success instead of reverting. TODO needs tests, and streamline the logic so it's less confusing
charles-cooper
force-pushed
the
checkable_raw_call
branch
from
October 17, 2021 18:32
b581ea7
to
b826f49
Compare
fubuloubu
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement #2400
How I did it
How to verify it
Check the tests!
Description for the changelog
Add
revert_on_failure
kwarg toraw_call
to allow handlingraw_call
failureCute Animal Picture