fix: rm seq_unchecked usage in codebase #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
+ Coverage 84.54% 84.56% +0.02%
==========================================
Files 93 93
Lines 9237 9228 -9
Branches 2091 2086 -5
==========================================
- Hits 7809 7804 -5
+ Misses 939 937 -2
+ Partials 489 487 -2
Continue to review full report at Codecov.
|
charles-cooper
requested changes
Oct 14, 2021
Charles: A string can be a symbol _sym_xyz or straight variable reference like x, in either case is either a PUSH or a DUP. Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
skellet0r
force-pushed
the
fix/rm-seq_unchecked
branch
from
893766f
to
ebcba80
Compare
| @@ -322,12 +322,6 @@ def _compile_to_assembly(code, withargs=None, existing_labels=None, break_dest=N | |||
| o.append("POP") | |||
| return o | |||
| # Seq without popping. | |||
There was a problem hiding this comment.
Suggested change
| # Seq without popping. |
charles-cooper
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
With the guidance of @charles-cooper, removed seq_unchecked usage in various places in the codebase.
How I did it
mainly just
s/seq_unchecked/seqHow to verify it
Tests pass as usual
Description for the changelog
fix: remove
seq_uncheckedusage in LLLCute Animal Picture