Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotate lll nodes returned by Expr and Stmt #2486

Merged

Conversation

skellet0r
Copy link
Contributor

@skellet0r skellet0r commented Oct 14, 2021

What I did

Minor quality of life improvement when viewing LLL.
This takes the work done in commit 5150ae1 and expands it to annotate all LLL nodes created by Stmt and Expr.

How I did it

Pretty simple, just set the annotate attribute during the init of both classes.

How to verify it

I'd recommend taking the diff of the output of vyper -f ir between the commits 12a8b6a (master) and 15a3816 (this PR)

diff

Description for the changelog

fix: better annotate the LLL output produced via vyper -f ir

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #2486 (15a3816) into master (12a8b6a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2486      +/-   ##
==========================================
+ Coverage   84.54%   84.56%   +0.02%     
==========================================
  Files          93       93              
  Lines        9237     9237              
  Branches     2091     2091              
==========================================
+ Hits         7809     7811       +2     
+ Misses        939      938       -1     
+ Partials      489      488       -1     
Impacted Files Coverage Δ
vyper/old_codegen/expr.py 79.10% <100.00%> (+0.04%) ⬆️
vyper/old_codegen/stmt.py 87.94% <100.00%> (-0.06%) ⬇️
vyper/lll/optimizer.py 84.07% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a8b6a...15a3816. Read the comment docs.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@charles-cooper charles-cooper merged commit 950661f into vyperlang:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants