optimize identity precompile #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use staticcall, we don't need to pass value=0, saving 2 bytes in bytecode / 3 gas at runtime Also, we do not need to have an assert after call to identity (the only way failure can happen is OOG and by that time it is too late to do anything anyway). Related: vyperlang#1929, vyperlang#1930
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 93 93
Lines 9228 9228
Branches 2086 2086
=======================================
Hits 7804 7804
Misses 937 937
Partials 487 487
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use staticcall, we don't need to pass value=0, saving 2 bytes in
bytecode / 3 gas at runtime
Also, we do not need to have an assert after call to identity (the only
way failure can happen is OOG and by that time it is too late to do
anything anyway).
Related: #1929, #1930
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture