Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add a README for LLL syntax and semantics #2494

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Oct 19, 2021

What I did

How I did it

How to verify it

View it at https://github.com/charles-cooper/vyper/blob/docs/lll/vyper/lll/README.md

Description for the changelog

Document Vyper's current IR - syntax and semantics.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #2494 (31e1079) into master (93a9579) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 31e1079 differs from pull request most recent head 3824183. Consider uploading reports for the commit 3824183 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
- Coverage   84.60%   84.59%   -0.01%     
==========================================
  Files          93       93              
  Lines        9228     9238      +10     
  Branches     2086     2088       +2     
==========================================
+ Hits         7807     7815       +8     
- Misses        935      936       +1     
- Partials      486      487       +1     
Impacted Files Coverage Δ
vyper/builtin_functions/functions.py 88.95% <0.00%> (-0.35%) ⬇️
vyper/cli/vyper_lll.py 0.00% <0.00%> (ø)
vyper/lll/optimizer.py 84.07% <0.00%> (ø)
vyper/lll/compile_lll.py 94.49% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a9579...3824183. Read the comment docs.

return x if x % 32 == 0 else x + 32 - (x % 32)
```

In LLL, `(ceil32 x)` is equivalent to `(with x x (sub (add x 31) (mod (x 1) 32)))`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is valid use of scoping, but for clarity it would be best not to re-use x in the with label here

@charles-cooper charles-cooper enabled auto-merge (squash) October 20, 2021 01:49
@charles-cooper charles-cooper merged commit 1081104 into vyperlang:master Oct 20, 2021
@charles-cooper charles-cooper deleted the docs/lll branch October 20, 2021 02:05
@charles-cooper charles-cooper mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants