Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slices of complex expressions #2500

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

charles-cooper
Copy link
Member

What I did

Fix #2499

How I did it

The existing code assumed the to-be-sliced LLL node was already in memory. But that's actually an optimization because bytes32 can live on the stack.

How to verify it

See the tests commit passes on this branch but not on master

Description for the changelog

Fix slice for complex expressions

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fubuloubu fubuloubu changed the title Fix slices of complex expressions fix: slices of complex expressions Oct 22, 2021
@charles-cooper charles-cooper merged commit 0faec01 into vyperlang:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add uint256s inside convert | Exception: Weird code element: l
2 participants