Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loaded limits for int128 and address #2506

Merged
merged 5 commits into from
Nov 4, 2021

Conversation

charles-cooper
Copy link
Member

What I did

Fix #2453

How I did it

How to verify it

Check tests. Also check out where variables start from, reduces gas usage somewhat.

@external
def foo():
    x: uint256 = 1

before
Screenshot from 2021-10-22 12-40-13

after
Screenshot from 2021-10-22 12-40-03

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #2506 (e36417e) into master (cec2c53) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2506      +/-   ##
==========================================
+ Coverage   84.63%   84.68%   +0.05%     
==========================================
  Files          94       93       -1     
  Lines        9273     9252      -21     
  Branches     2093     2089       -4     
==========================================
- Hits         7848     7835      -13     
+ Misses        940      934       -6     
+ Partials      485      483       -2     
Impacted Files Coverage Δ
vyper/builtin_functions/convert.py 75.22% <100.00%> (+0.11%) ⬆️
vyper/builtin_functions/functions.py 88.91% <100.00%> (-0.07%) ⬇️
vyper/old_codegen/parser_utils.py 82.78% <100.00%> (ø)
vyper/utils.py 84.76% <100.00%> (-0.40%) ⬇️
vyper/lll/optimizer.py 85.35% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec2c53...e36417e. Read the comment docs.

@charles-cooper charles-cooper force-pushed the remove_loaded_limits branch 2 times, most recently from a25a4d4 to 0565b5e Compare October 22, 2021 21:24
@fubuloubu fubuloubu merged commit 98eff0a into vyperlang:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove loaded limits
3 participants