Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI flag to disable optimizer #2522

Merged
merged 13 commits into from
Nov 19, 2021

Conversation

charles-cooper
Copy link
Member

What I did

Fix #2516

How I did it

Add no-optimize flag, thread through the codebase and disable LLL+assembly optimizations

How to verify it

Build, compile something with vyper --no-optimize -f ir foo.vy and vyper --no-optimize -f asm foo.vy and see the difference.

Description for the changelog

Add --no-optimize flag to the CLI

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

vyper/cli/vyper_compile.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

also, should probably run the test suite with this flag active and inactive, and (almost) all tests should pass

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #2522 (ea8c28b) into master (4a1ace0) will decrease coverage by 33.68%.
The diff coverage is 61.11%.

❗ Current head ea8c28b differs from pull request most recent head 64eed91. Consider uploading reports for the commit 64eed91 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2522       +/-   ##
===========================================
- Coverage   85.66%   51.97%   -33.69%     
===========================================
  Files          90       90               
  Lines        9025     9029        +4     
  Branches     2069     2071        +2     
===========================================
- Hits         7731     4693     -3038     
- Misses        815     3736     +2921     
- Partials      479      600      +121     
Impacted Files Coverage Δ
vyper/cli/vyper_compile.py 20.00% <0.00%> (-53.95%) ⬇️
vyper/cli/vyper_json.py 10.35% <20.00%> (-74.85%) ⬇️
vyper/lll/compile_lll.py 76.97% <66.66%> (-17.98%) ⬇️
vyper/compiler/phases.py 78.57% <87.50%> (-16.23%) ⬇️
vyper/compiler/__init__.py 74.28% <100.00%> (-11.43%) ⬇️
vyper/builtin_interfaces/ERC20Detailed.py 0.00% <0.00%> (-100.00%) ⬇️
vyper/ast/natspec.py 12.34% <0.00%> (-86.42%) ⬇️
vyper/lll/s_expressions.py 5.88% <0.00%> (-85.30%) ⬇️
vyper/old_codegen/external_call.py 13.20% <0.00%> (-81.14%) ⬇️
vyper/cli/utils.py 18.42% <0.00%> (-73.69%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1ace0...64eed91. Read the comment docs.

also, rename get_input_dict_settings to `get_evm_version` which is what
it does
@charles-cooper charles-cooper marked this pull request as ready for review November 18, 2021 19:48
@charles-cooper
Copy link
Member Author

@fubuloubu got the optimization parameter working as a command line flag, and added several more workflow actions to test. we might want to add as a required test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI option to disable optimization
3 participants