-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CLI flag to disable optimizer #2522
add CLI flag to disable optimizer #2522
Conversation
also, should probably run the test suite with this flag active and inactive, and (almost) all tests should pass |
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2522 +/- ##
===========================================
- Coverage 85.66% 51.97% -33.69%
===========================================
Files 90 90
Lines 9025 9029 +4
Branches 2069 2071 +2
===========================================
- Hits 7731 4693 -3038
- Misses 815 3736 +2921
- Partials 479 600 +121
Continue to review full report at Codecov.
|
also, rename get_input_dict_settings to `get_evm_version` which is what it does
7f8cf07
to
4306f48
Compare
@fubuloubu got the optimization parameter working as a command line flag, and added several more workflow actions to test. we might want to add as a required test |
What I did
Fix #2516
How I did it
Add no-optimize flag, thread through the codebase and disable LLL+assembly optimizations
How to verify it
Build, compile something with
vyper --no-optimize -f ir foo.vy
andvyper --no-optimize -f asm foo.vy
and see the difference.Description for the changelog
Add
--no-optimize
flag to the CLICute Animal Picture