Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax an assertion in packing external call args #2526

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Nov 5, 2021

the number of args passed could be somewhere in between
base args + 0 kwargs and
base args + all kwargs

What I did

Fix #2520 and #2374

How I did it

#2447 partially fixed the bug but an assertion introduced in that PR was too aggressive.

How to verify it

vyper -f ir of the code in the issues

Description for the changelog

Fix calls to external functions involving kwargs

Cute Animal Picture

image

the number of args passed could be somewhere in between
base args + 0 kwargs and
base args + all kwargs
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #2526 (3b09fab) into master (f31bd4a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2526   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files          93       93           
  Lines        9307     9307           
  Branches     2099     2099           
=======================================
  Hits         7881     7881           
  Misses        940      940           
  Partials      486      486           
Impacted Files Coverage Δ
vyper/old_codegen/external_call.py 94.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31bd4a...3b09fab. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vyper.exceptions.TypeCheckFailure: pack_arguments did not return a value
3 participants