feat: implement append and pop for dynarray #2615

charles-cooper · 2022-01-22T13:47:53Z

What I did

implement #2611

How I did it

add "append" and "pop" to typechecker, thread through codegen
make some minor changes to variables in LLL to prevent name shadowing

How to verify it

see tests

Description for the changelog

Cute Animal Picture

codecov-commenter · 2022-01-22T13:58:11Z

Codecov Report

Merging #2615 (ca3af6e) into master (548d35d) will increase coverage by 0.02%.
The diff coverage is 89.10%.

❗ Current head ca3af6e differs from pull request most recent head e5f13b9. Consider uploading reports for the commit e5f13b9 to get more accurate results

@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
+ Coverage   86.25%   86.27%   +0.02%     
==========================================
  Files          91       91              
  Lines        9579     9657      +78     
  Branches     2423     2439      +16     
==========================================
+ Hits         8262     8332      +70     
- Misses        823      828       +5     
- Partials      494      497       +3

Impacted Files	Coverage Δ
vyper/lll/optimizer.py	`86.28% <0.00%> (-1.51%)`	⬇️
vyper/semantics/types/bases.py	`83.95% <ø> (ø)`
vyper/semantics/validation/annotation.py	`90.60% <71.42%> (-1.07%)`	⬇️
vyper/semantics/types/function.py	`84.92% <80.00%> (-0.49%)`	⬇️
vyper/semantics/types/indexable/sequence.py	`88.09% <83.33%> (-0.34%)`	⬇️
vyper/codegen/core.py	`84.21% <97.82%> (+0.98%)`	⬆️
vyper/codegen/expr.py	`79.28% <100.00%> (+0.19%)`	⬆️
vyper/codegen/stmt.py	`89.02% <100.00%> (+0.51%)`	⬆️
vyper/semantics/validation/local.py	`91.34% <100.00%> (ø)`
vyper/semantics/validation/utils.py	`91.03% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548d35d...e5f13b9. Read the comment docs.

WIP: frontend for dynamic array functions

we can run into issues if loop variables get repeated in the same scope, for safety just don't allow it.

clarify some code by moving some optimizations down into optimizer also, block expressions like `empty(uint256[3])[ix]`

for maintainability - so it's easier to track where `empty` literals get handled.

this is important because it is used in array bounds checks

This reverts commit 9f6c3a7.

in some tests when optimizations are off, apparently the gas usage can increase base fee past 0

lgtm-com · 2022-02-14T18:16:23Z

This pull request introduces 3 alerts when merging fcfd1ea into 5efb11a - view on LGTM.com

new alerts:

1 for Conflicting attributes in base classes
1 for Missing call to `__init__` during object initialization
1 for Variable defined multiple times

lgtm-com · 2022-02-14T23:28:55Z

This pull request introduces 3 alerts when merging fb6a127 into 1368adb - view on LGTM.com

new alerts:

1 for Conflicting attributes in base classes
1 for Missing call to `__init__` during object initialization
1 for Variable defined multiple times

lgtm-com · 2022-02-15T00:08:47Z

This pull request introduces 3 alerts when merging e08f0d3 into 1368adb - view on LGTM.com

new alerts:

1 for Conflicting attributes in base classes
1 for Missing call to `__init__` during object initialization
1 for Variable defined multiple times

lgtm-com · 2022-02-15T00:39:42Z

This pull request introduces 3 alerts when merging f1378c6 into 548d35d - view on LGTM.com

new alerts:

1 for Conflicting attributes in base classes
1 for Missing call to `__init__` during object initialization
1 for Variable defined multiple times

so `for x in [..]` gets the right type assigned.

lgtm-com · 2022-02-15T01:29:04Z

This pull request introduces 2 alerts when merging ca3af6e into 548d35d - view on LGTM.com

new alerts:

1 for Conflicting attributes in base classes
1 for Missing call to `__init__` during object initialization

lgtm-com · 2022-02-15T14:12:06Z

This pull request introduces 1 alert when merging e5f13b9 into 43f491f - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization

fubuloubu · 2022-02-15T15:34:34Z

tests/parser/types/test_dynamic_array.py

+    self.my_array.append(x)  # fail
+    return self.my_array
+    """,
+        lambda x: None,


This raises right?

yeah - return of the sentinel None maps to assert_tx_failed in the test

wip: codegen for dynarrray append and pop

5ee8022

charles-cooper and others added 28 commits February 5, 2022 15:58

Merge branch 'master' into dyn_array_functions

826d626

fix off-by-one in dynarray pop

a2dd0ca

feat: add dynarray function typedef

fcc6f5b

update validation for dynarray functions

a38902e

rename to MemberFunctionDefinition

f282dff

remove stray print stmt

434728b

remove stray print stmt 2

fb01036

Merge pull request #7 from tserg/feat/dynarray_fn

914eba8

WIP: frontend for dynamic array functions

increase strictness on internally generated names

dc00d85

we can run into issues if loop variables get repeated in the same scope, for safety just don't allow it.

add sanity check in LLLnode ctor

30dd349

streamline getelemptr and make_setter

bd65425

clarify some code by moving some optimizations down into optimizer also, block expressions like `empty(uint256[3])[ix]`

replace None with ~empty dummy macro

15d3d90

for maintainability - so it's easier to track where `empty` literals get handled.

add test for abi_encode buffer overrun

b9e481e

add assertion for function frame invariant

ad6bf44

fix array indexing

345e74d

fix frame size assertion

a9f0e81

fix clamp for negative array indexes

8f9ff8c

fix slice fuzz test

9c99960

fix lint

01ce4e8

fix lint, mypy

8c7f101

simplify optimizer for clarity

64c3cc9

add uclamplt rule to optimizer

a4cbff8

this is important because it is used in array bounds checks

remove a bad fastpath return

293de45

add test for slice clobber

efd131f

add test for bytes32 slice

e3e947b

bump the extra gas budget

9f6c3a7

Revert "bump the extra gas budget"

6e0d995

This reverts commit 9f6c3a7.

set maxfee for london txns

8d4d7ef

in some tests when optimizations are off, apparently the gas usage can increase base fee past 0

charles-cooper added 5 commits February 14, 2022 12:46

fix location for complex pops

1a9f847

lint stmt.py

357cc19

lint expr.py

33f902b

add tests for append/pop complex types

1f72331

add another subtype to complex test

fcfd1ea

charles-cooper added 7 commits February 14, 2022 17:27

change how code template params are passed

0c76f80

fix typo in fn call

ce9703e

Merge branch 'master' into refactor_slice

d434b26

Merge branch 'refactor_slice' into wip

db2bb37

fix memzero fastpath for dynarray literals

5e51631

improve pop length check

1a2e39c

fix lint

fb6a127

Merge branch 'master' into dyn_array_functions

f1378c6

charles-cooper force-pushed the dyn_array_functions branch from e08f0d3 to f1378c6 Compare February 15, 2022 00:24

fix some shadowed LLL names

3289fd2

charles-cooper added 3 commits February 15, 2022 00:50

remove redundant variable definition

12ed73b

increase priority of static arrays in typechecker

6d73914

so `for x in [..]` gets the right type assigned.

add a note about inheritance

ca3af6e

charles-cooper marked this pull request as ready for review February 15, 2022 01:14

charles-cooper added 2 commits February 15, 2022 13:52

fix DynamicArrayDefinition inheritance hierarchy

65839f9

fix a comment

e5f13b9

fubuloubu approved these changes Feb 15, 2022

View reviewed changes

charles-cooper merged commit 27cec1b into vyperlang:master Feb 15, 2022

charles-cooper deleted the dyn_array_functions branch February 15, 2022 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement append and pop for dynarray #2615

feat: implement append and pop for dynarray #2615

charles-cooper commented Jan 22, 2022 •

edited

Loading

codecov-commenter commented Jan 22, 2022 •

edited

Loading

lgtm-com bot commented Feb 14, 2022

lgtm-com bot commented Feb 14, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

fubuloubu Feb 15, 2022

charles-cooper Feb 15, 2022

feat: implement append and pop for dynarray #2615

feat: implement append and pop for dynarray #2615

Conversation

charles-cooper commented Jan 22, 2022 • edited Loading

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

codecov-commenter commented Jan 22, 2022 • edited Loading

Codecov Report

lgtm-com bot commented Feb 14, 2022

lgtm-com bot commented Feb 14, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

lgtm-com bot commented Feb 15, 2022

fubuloubu Feb 15, 2022

Choose a reason for hiding this comment

charles-cooper Feb 15, 2022

Choose a reason for hiding this comment

charles-cooper commented Jan 22, 2022 •

edited

Loading

codecov-commenter commented Jan 22, 2022 •

edited

Loading