feat: add gasprice to tx object namespace #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Jan 26, 2022
| @@ -25,6 +25,7 @@ Name Type Value | |||
| ``msg.sender`` ``address`` Sender of the message (current call) | |||
| ``msg.value`` ``uint256`` Number of wei sent with the message | |||
| ``tx.origin`` ``address`` Sender of the transaction (full call chain) | |||
| ``tx.gasprice`` ``uint256`` Gas price of current transaction in wei | |||
There was a problem hiding this comment.
What is this set to post-EIP1559?
There was a problem hiding this comment.
For 1559 (type 2) txs, it'll just match BASEFEE, but for legacy txs it'll be whatever gasprice was set when the tx was built.
There was a problem hiding this comment.
Mainly useful for EVM chains that don't support LONDON yet
fubuloubu
approved these changes
Jan 26, 2022
tserg
pushed a commit
to tserg/vyper
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add
gaspricetotxnamespaceHow to verify it
Check test
Description for the changelog
feat: add gasprice to tx object namespace
Cute Animal Picture