-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unsafe arithmetic ops #2629
Conversation
This pull request introduces 1 alert and fixes 1 when merging 606f151 into 82f44ee - view on LGTM.com new alerts:
fixed alerts:
|
ebb1c6b
to
204cb96
Compare
Codecov Report
@@ Coverage Diff @@
## master #2629 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 91 91
Lines 9739 9787 +48
Branches 2466 2479 +13
=======================================
+ Hits 8404 8446 +42
- Misses 833 838 +5
- Partials 502 503 +1
Continue to review full report at Codecov.
|
204cb96
to
ffce251
Compare
This pull request introduces 1 alert when merging ffce251 into e480e91 - view on LGTM.com new alerts:
|
3e9b96d
to
d910d1b
Compare
This pull request introduces 1 alert and fixes 1 when merging d910d1b into e480e91 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 1 when merging 7cb3379 into e480e91 - view on LGTM.com new alerts:
fixed alerts:
|
luckily codegen is really easy - just compile straight to the EVM ops
add tests actually the codegen is not so easy for non-[u]int256 types.
7cb3379
to
768abf9
Compare
This pull request introduces 2 alerts when merging 768abf9 into 3de52b3 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 748db64 into 3de52b3 - view on LGTM.com new alerts:
|
8c94a03
to
85ef71c
Compare
What I did
introduce unsafe math ops for #2429
How I did it
add unsafe add/sub/mul/div builtins. for int types that are smaller than 256 bits, they perform wrapping arithmetic
How to verify it
check the tests
Commit message
(tbd)
Description for the changelog
Add
unsafe_
arithmetic ops which don't use checked arithmeticCute Animal Picture