Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable msg.* env variables in internal functions #2632

Merged
merged 6 commits into from
Feb 8, 2022

Conversation

charles-cooper
Copy link
Member

What I did

Fix #2631

How I did it

Remove the restrictions, fix tests

How to verify it

Check tests

Description for the changelog

re-enable msg.* env variables in internal functions

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #2632 (86ab6be) into master (82f44ee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 86ab6be differs from pull request most recent head a63ab76. Consider uploading reports for the commit a63ab76 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
- Coverage   86.55%   86.54%   -0.01%     
==========================================
  Files          92       92              
  Lines        9460     9456       -4     
  Branches     2400     2398       -2     
==========================================
- Hits         8188     8184       -4     
  Misses        781      781              
  Partials      491      491              
Impacted Files Coverage Δ
vyper/codegen/expr.py 80.69% <100.00%> (ø)
vyper/semantics/validation/local.py 91.37% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f44ee...a63ab76. Read the comment docs.

@charles-cooper charles-cooper enabled auto-merge (squash) February 7, 2022 01:41
c = get_contract(code)
addr = w3.eth.accounts[0]
assert c.whoami() == addr
# TODO figure out why this does not work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs docs updates

@charles-cooper charles-cooper merged commit 8bb5dd1 into vyperlang:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIP: re-enable msg.* environment variables in internal functions
3 participants