Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build for aarch64 #2687

Merged
merged 5 commits into from
May 18, 2023
Merged

Conversation

kelvinfan001
Copy link
Contributor

@kelvinfan001 kelvinfan001 commented Mar 3, 2022

What I did

Edit Makefile to specify target arch as universal2 for pyinstaller.

Note: Pending fix in actions/runner-images#4133.

fixes #3305

How I did it

Add --target-architecture=universal2 in the make freeze rule for macOS.

xref: #2675 (comment)

How to verify it

Run the workflow to build artifacts.

Description for the changelog

Create official binary releases for aarch64 machines.

Cute Animal Picture

AdobeStock_209028852

To also build official binary releases for aarch64 machines.

xref: vyperlang#2675 (comment)
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #2687 (f57e4c5) into master (4f9f813) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   89.09%   89.12%   +0.02%     
==========================================
  Files          84       84              
  Lines       10763    10763              
  Branches     2452     2452              
==========================================
+ Hits         9589     9592       +3     
+ Misses        781      776       -5     
- Partials      393      395       +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper
Copy link
Member

charles-cooper commented Mar 3, 2022

note: this would break current macos-latest in the unix build matrix. see e.g. https://github.com/charles-cooper/vyper/runs/5401409429?check_suite_focus=true
Screenshot from 2022-03-02 20-15-52

we will have to wait for the fix in actions/runner-images#4133 to be merged before merging this.

@charles-cooper
Copy link
Member

another issue seems to be that the pycryptodome .so is not a fat binary even when python is
https://github.com/charles-cooper/vyper/runs/5403151996?check_suite_focus=true#step:3:627
Screenshot from 2022-03-02 22-55-35

@charles-cooper
Copy link
Member

another issue seems to be that the pycryptodome .so is not a fat binary even when python is https://github.com/charles-cooper/vyper/runs/5403151996?check_suite_focus=true#step:3:627 Screenshot from 2022-03-02 22-55-35

it needs to be built from source - charles-cooper@c47687a

@charles-cooper
Copy link
Member

@kelvinfan001 looks like the upstream issue was fixed! do you mind if i update this PR or would you like to work on it?

@kelvinfan001
Copy link
Contributor Author

@charles-cooper thanks for the update! Feel free to update the PR, as I am no longer working on this.

@charles-cooper
Copy link
Member

blocked on actions/setup-python#439

@asafyish
Copy link

asafyish commented Feb 9, 2023

Any update on this ? Almost all new macbooks are M1 & M2 and we still don't have support for it, which is very wierd since the entire project is in python.

@fubuloubu
Copy link
Member

Seems like all blockers are resolved, will let @charles-cooper do a final review and merge

@charles-cooper
Copy link
Member

I don't think the blockers were resolved, there was some issue with universal2 images upstream. In any case the build needs to be revisited

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper enabled auto-merge (squash) May 18, 2023 13:29
@charles-cooper charles-cooper changed the title feat: Build for aarch64 feat: build for aarch64 May 18, 2023
@charles-cooper charles-cooper enabled auto-merge (squash) May 18, 2023 13:59
@charles-cooper charles-cooper merged commit 8aaaa9d into vyperlang:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install vyper on macbook pro M2 Pro chipset
5 participants