feat: add select opcode to LLL
#2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
commented
Mar 4, 2022
this is an optimizing opcode for ternary operations. this is useful because even in the presence of perfect liveness analysis, branches still need to issue more POPs than are required with a specialized `select` opcode. this commit also modifies the `min/max` builtins to use the new opcode, as an example.
charles-cooper
force-pushed
the
lll_select
branch
from
9198d32
to
d43dc60
Compare
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 86.27% 86.29% +0.01%
==========================================
Files 91 91
Lines 9743 9754 +11
Branches 2467 2469 +2
==========================================
+ Hits 8406 8417 +11
Misses 834 834
Partials 503 503
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an optimizing opcode for ternary operations. this is useful
because even in the presence of perfect liveness analysis, branches
still need to issue more POPs than are required with a specialized
selectopcode.this commit also modifies the
min/maxto use the new opcode, as anexample.
fixes #2382
h/t to @yaronvel - https://twitter.com/yaron_velner/status/1499461195073568769
What I did
How I did it
How to verify it
tests still pass
Description for the changelog
Cute Animal Picture