-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add all integer and bytes types #2705
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
==========================================
- Coverage 86.98% 86.17% -0.82%
==========================================
Files 91 91
Lines 9846 9845 -1
Branches 2469 2465 -4
==========================================
- Hits 8565 8484 -81
- Misses 798 871 +73
- Partials 483 490 +7
Continue to review full report at Codecov.
|
550c4c1
to
bc6e7bd
Compare
32e01d5
to
d1d09bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of so many type in gore's is a bit of an issue for me, but can be refactored later
This pull request introduces 1 alert when merging d1d09bf into a125a88 - view on LGTM.com new alerts:
|
This commit adds all intN/uintN/bytesM types, bringing Vyper to full implementation of ABIv2 (technically in line with solidity as they do not have fixedMxN/ufixedMxN types). Practically speaking, these are the types that people will expect to be able to use. The implementation is a first pass. It generates the new types with Python dynamic class generation since the vyper/semantics type system has a 1:1 correspondence between Vyper and Python types. Future work should include a generous refactoring of the approach. Before release, we need to add more tests of arithmetic, and any builtin functions which accept integers and bytesM types.
What I did
resolves #2559
Commit message
This commit adds all intN/uintN/bytesM types, bringing vyper to full
implementation of ABIv2 (technically in line with solidity as they do
not have fixedMxN/ufixedMxN types). Practically speaking, these are the
types that people will expect to be able to use.
The implementation is a first pass. It generates the new types with
Python dynamic class generation since the vyper/semantics type system
has a 1:1 correspondence between Vyper and Python types. Future work
should include a generous refactoring of the approach. Before release,
we need to add more tests of arithmetic, and any builtin functions which
accept integers and bytesM types.
Description for the changelog
Cute Animal Picture