-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bytes20 literals #2782
Merged
charles-cooper
merged 14 commits into
vyperlang:master
from
charles-cooper:fix_bytes20_literals
Apr 14, 2022
Merged
fix bytes20 literals #2782
charles-cooper
merged 14 commits into
vyperlang:master
from
charles-cooper:fix_bytes20_literals
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2782 +/- ##
==========================================
- Coverage 87.43% 87.18% -0.25%
==========================================
Files 93 93
Lines 9939 9956 +17
Branches 2465 2424 -41
==========================================
- Hits 8690 8680 -10
- Misses 783 800 +17
- Partials 466 476 +10
Continue to review full report at Codecov.
|
charles-cooper
force-pushed
the
fix_bytes20_literals
branch
from
April 14, 2022 13:31
a6bc66d
to
b3aaf4d
Compare
fubuloubu
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #2780
also fix #2790 by blocking underscores in hex literals.
How I did it
propagate more type info down into codegen. note the bandaid in expr.py due to type annotations sometimes missing.
How to verify it
see tests
Commit message
Description for the changelog
Cute Animal Picture