fix: signature for get_type_from_annotation #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2805 +/- ##
===========================================
- Coverage 87.47% 51.72% -35.76%
===========================================
Files 94 94
Lines 10003 10000 -3
Branches 2480 2432 -48
===========================================
- Hits 8750 5172 -3578
- Misses 785 4302 +3517
- Partials 468 526 +58
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Apr 17, 2022
in several places, the extra args (e.g. is_constant) are passed as positional args instead of kwargs, resulting in a TypeError, instead of raising the user-friendly exception. this commit adds `*args` to the signature so that the TypeEror is not raised.
charles-cooper
force-pushed
the
fix_minor_bugs
branch
from
e723046 to
dcaee9a
Compare
charles-cooper
changed the title
fubuloubu
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #2801
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture