Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add print builtin #2818

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

charles-cooper
Copy link
Member

equivalent of nomic's console.log

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2818 (3b70ed7) into master (c270363) will decrease coverage by 30.24%.
The diff coverage is 31.25%.

@@             Coverage Diff             @@
##           master    #2818       +/-   ##
===========================================
- Coverage   87.47%   57.22%   -30.25%     
===========================================
  Files          94       94               
  Lines       10003    10034       +31     
  Branches     2480     2438       -42     
===========================================
- Hits         8750     5742     -3008     
- Misses        785     3686     +2901     
- Partials      468      606      +138     
Impacted Files Coverage Δ
vyper/builtin_functions/functions.py 57.57% <26.92%> (-33.19%) ⬇️
vyper/ast/nodes.py 73.46% <50.00%> (-20.74%) ⬇️
vyper/utils.py 72.45% <50.00%> (-14.82%) ⬇️
vyper/builtin_interfaces/ERC165.py 0.00% <0.00%> (-100.00%) ⬇️
vyper/builtin_interfaces/ERC20Detailed.py 0.00% <0.00%> (-100.00%) ⬇️
vyper/ir/s_expressions.py 5.88% <0.00%> (-88.24%) ⬇️
vyper/ast/natspec.py 12.34% <0.00%> (-86.42%) ⬇️
vyper/codegen/external_call.py 12.74% <0.00%> (-83.34%) ⬇️
vyper/semantics/validation/levenshtein_utils.py 16.00% <0.00%> (-76.00%) ⬇️
vyper/cli/utils.py 16.66% <0.00%> (-71.43%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c270363...3b70ed7. Read the comment docs.

equivalent of nomic's console.log
@charles-cooper charles-cooper marked this pull request as ready for review April 20, 2022 20:59
args_as_tuple = IRnode.from_list(["multi"] + [x for x in args], typ=args_tuple_t)
args_abi_t = args_tuple_t.abi_type
# create a signature like "log(uint256)"
sig = "log" + "(" + ",".join([arg.typ.abi_type.selector_name() for arg in args]) + ")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be log (built in keyword) or should it be print?

@charles-cooper charles-cooper enabled auto-merge (squash) April 21, 2022 16:47
@charles-cooper charles-cooper merged commit 981ec17 into vyperlang:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants