ux: reverse order in which exceptions are reported #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit reverses the order in which multiple exceptions are reported. this is a usability issue because sometimes when exceptions cascade, the first error is the most meaningful (other errors depend on the first error being fixed).
Codecov Report
@@ Coverage Diff @@
## master #2838 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 94 94
Lines 10054 10054
Branches 2490 2490
=======================================
Hits 8785 8785
Misses 802 802
Partials 467 467
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit reverses the order in which multiple exceptions are
reported. this is a usability issue because sometimes when exceptions
cascade, the first error is the most meaningful (other errors depend on
the first error being fixed).
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture