Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: more arithmetic optimizations" #2872

Closed
wants to merge 1 commit into from

Conversation

charles-cooper
Copy link
Member

Reverts #2647

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #2872 (874bbcc) into master (42a372e) will decrease coverage by 0.14%.
The diff coverage is 83.23%.

@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
- Coverage   87.68%   87.54%   -0.15%     
==========================================
  Files          94       94              
  Lines       10201    10140      -61     
  Branches     2505     2493      -12     
==========================================
- Hits         8945     8877      -68     
- Misses        790      800      +10     
+ Partials      466      463       -3     
Impacted Files Coverage Δ
vyper/builtin_functions/functions.py 89.23% <ø> (ø)
vyper/exceptions.py 94.49% <ø> (-0.06%) ⬇️
vyper/ir/optimizer.py 80.00% <70.65%> (-11.41%) ⬇️
vyper/ir/compile_ir.py 94.66% <97.87%> (+0.96%) ⬆️
vyper/builtin_functions/convert.py 90.49% <100.00%> (+0.03%) ⬆️
vyper/codegen/core.py 84.55% <100.00%> (-0.30%) ⬇️
vyper/codegen/expr.py 80.73% <100.00%> (ø)
vyper/codegen/ir_node.py 92.83% <100.00%> (+0.02%) ⬆️
vyper/codegen/return_.py 94.87% <100.00%> (ø)
vyper/codegen/stmt.py 88.09% <100.00%> (+0.19%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a372e...874bbcc. Read the comment docs.

@charles-cooper
Copy link
Member Author

closing in favor of #2868

@charles-cooper charles-cooper deleted the revert-2647-rewrite_optimizer3 branch May 28, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants