feat: allow msg.data in raw_call without slice #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a common use case for raw_call is to forward all calldata to an implementation or logic contract of some kind. this enables that without requiring the length of msg.data to be known. it does this by simply copying calldata to the location pointed to by `msize`. this commit also fixes an annotation in abi_decode, and slightly cleans up the logic in the raw_call implementation.
Codecov Report
@@ Coverage Diff @@
## master #2902 +/- ##
=======================================
Coverage 88.04% 88.05%
=======================================
Files 95 95
Lines 10435 10442 +7
Branches 2511 2512 +1
=======================================
+ Hits 9188 9195 +7
Misses 790 790
Partials 457 457
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jun 9, 2022
ThiwakonPB
pushed a commit
to ThiwakonPB/vyper
that referenced
this pull request
Jun 13, 2022
a common use case for raw_call is to forward all calldata to an implementation or logic contract of some kind. however, currently vyper only allows msg.data inside of slice() or len(); this does not allow one to forward calldata of any size. this enables that use case without requiring the length of msg.data to be known. it does this by simply copying calldata to the location pointed to by `msize`. this commit also fixes an annotation in abi_decode, and slightly cleans up the logic in the raw_call implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as title
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture