-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable dynarrays of strings #2922
enable dynarrays of strings #2922
Conversation
the codegen should all work - we just blocked it semantically to match (static) arrays of strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some test cases
This pull request introduces 1 alert when merging 651100b into 4e38ec4 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2922 +/- ##
==========================================
- Coverage 88.47% 86.20% -2.28%
==========================================
Files 97 97
Lines 10613 11537 +924
Branches 2527 2936 +409
==========================================
+ Hits 9390 9945 +555
- Misses 770 1095 +325
- Partials 453 497 +44
Continue to review full report at Codecov.
|
What I did
as title.
How I did it
the codegen should all work - we just blocked it semantically to match
(static) arrays of strings.
How to verify it
Commit message
Description for the changelog
Cute Animal Picture