Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dynarrays of strings #2922

Merged
merged 6 commits into from
Jun 19, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 19, 2022

What I did

as title.

How I did it

the codegen should all work - we just blocked it semantically to match
(static) arrays of strings.

How to verify it

Commit message

Description for the changelog

Cute Animal Picture

image

the codegen should all work - we just blocked it semantically to match
(static) arrays of strings.
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some test cases

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 19, 2022

This pull request introduces 1 alert when merging 651100b into 4e38ec4 - view on LGTM.com

new alerts:

  • 1 for Unused import

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #2922 (4b0bacf) into master (4e38ec4) will decrease coverage by 2.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2922      +/-   ##
==========================================
- Coverage   88.47%   86.20%   -2.28%     
==========================================
  Files          97       97              
  Lines       10613    11537     +924     
  Branches     2527     2936     +409     
==========================================
+ Hits         9390     9945     +555     
- Misses        770     1095     +325     
- Partials      453      497      +44     
Impacted Files Coverage Δ
vyper/semantics/types/indexable/sequence.py 87.85% <ø> (-0.26%) ⬇️
vyper/semantics/validation/utils.py 81.04% <ø> (-10.26%) ⬇️
vyper/codegen/function_definitions/utils.py 80.00% <0.00%> (-20.00%) ⬇️
vyper/semantics/types/user/enum.py 67.81% <0.00%> (-12.89%) ⬇️
vyper/builtin_functions/functions.py 85.04% <0.00%> (-9.09%) ⬇️
vyper/codegen/core.py 78.50% <0.00%> (-6.08%) ⬇️
vyper/codegen/expr.py 79.34% <0.00%> (-4.38%) ⬇️
vyper/codegen/types/types.py 85.34% <0.00%> (-3.01%) ⬇️
vyper/ast/nodes.py 91.31% <0.00%> (-2.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e38ec4...4b0bacf. Read the comment docs.

@charles-cooper charles-cooper enabled auto-merge (squash) June 19, 2022 20:22
@charles-cooper charles-cooper disabled auto-merge June 19, 2022 20:29
@charles-cooper charles-cooper merged commit eb2becf into vyperlang:master Jun 19, 2022
@charles-cooper charles-cooper deleted the dynarray_strings branch June 19, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants