-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error map #2939
Merged
charles-cooper
merged 6 commits into
vyperlang:master
from
charles-cooper:feat/error_map
Jul 3, 2022
Merged
feat: error map #2939
charles-cooper
merged 6 commits into
vyperlang:master
from
charles-cooper:feat/error_map
Jul 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2939 +/- ##
==========================================
- Coverage 88.32% 88.31% -0.01%
==========================================
Files 97 97
Lines 10771 10784 +13
Branches 2565 2568 +3
==========================================
+ Hits 9513 9524 +11
- Misses 800 802 +2
Partials 458 458
Continue to review full report at Codecov.
|
LGTM |
fubuloubu
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
add an error map to source_map output. this makes it easier for downstream tooling to detect why a revert was issued (without having to rely on heuristics or explicit returndata). this also paves the way for brownie-style dev revert strings to be supported by at the language level.
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture