fix: change tokenURL to tokenURI, according to EIP-721 #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EIP-721, the ERC-721 Non-Fungible Token Standard, optional metadata extension. Defined a function called "tokenURI" ` function tokenURI(uint256 _tokenId) external view returns (string); ` https://eips.ethereum.org/EIPS/eip-721
fubuloubu
approved these changes
Jul 1, 2022
fubuloubu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 97 97
Lines 10773 10773
Branches 2566 2566
=======================================
Hits 9513 9513
Misses 802 802
Partials 458 458 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EIP-721, the ERC-721 Non-Fungible Token Standard, optional metadata extension. Defined a function called "tokenURI"
function tokenURI(uint256 _tokenId) external view returns (string);https://eips.ethereum.org/EIPS/eip-721
What I did
I changed "tokenURL" to "tokenURI"