Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement signed shift #2964

Merged
merged 12 commits into from
Jul 22, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jul 11, 2022

What I did

add shift for int256

How I did it

How to verify it

Commit message

add shift for signed integers. use SAR instruction for the right shift,
and disable SAR emulation for pre-constantinople arches since the
emulation is not simple.

- fix bad argtypes
- wrap evm_pow to prevent optimizer from hanging on large inputs

Description for the changelog

implement shift for signed integers

Cute Animal Picture

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2964 (d1800b6) into master (c3e43d7) will decrease coverage by 0.02%.
The diff coverage is 94.11%.

❗ Current head d1800b6 differs from pull request most recent head 5a185ca. Consider uploading reports for the commit 5a185ca to get more accurate results

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   88.16%   88.13%   -0.03%     
==========================================
  Files          97       97              
  Lines       10820    10810      -10     
  Branches     2569     2564       -5     
==========================================
- Hits         9539     9527      -12     
- Misses        823      825       +2     
  Partials      458      458              
Impacted Files Coverage Δ
vyper/codegen/core.py 84.90% <0.00%> (ø)
vyper/builtin_functions/functions.py 90.86% <100.00%> (-0.11%) ⬇️
vyper/ir/optimizer.py 95.03% <100.00%> (ø)
vyper/utils.py 90.00% <100.00%> (+0.16%) ⬆️
vyper/codegen/ir_node.py 91.69% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@charles-cooper charles-cooper enabled auto-merge (squash) July 21, 2022 13:54
@charles-cooper charles-cooper enabled auto-merge (squash) July 22, 2022 18:58
@charles-cooper charles-cooper merged commit f6a2dcb into vyperlang:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants