-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: front-end type system #2974
refactor: front-end type system #2974
Conversation
This pull request introduces 13 alerts and fixes 2 when merging 53de3d1 into 1d1ef5d - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 10 alerts and fixes 2 when merging 516a8f7 into 1d1ef5d - view on LGTM.com new alerts:
fixed alerts:
|
remove it -- we can just handle it on VyperType
merge builtin_functions/ and builtin_interfaces/ to builtins/
This pull request introduces 1 alert and fixes 3 when merging 1e10958 into 2d18e60 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chad work ser.
I definitely like the reorganization done, adds clarity.
This pull request fixes 3 alerts when merging 7e565bd into 2d18e60 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request fixes 3 alerts when merging 7a7a339 into 2d18e60 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request fixes 3 alerts when merging c7e23c4 into 2d18e60 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
What I did
refactor type system. redo the type hierarchy - instead of distinction between "Primitives" and "Definitions", have single type system + ExprInfo
merge old and new type systemswill do this in a follow up PRbuiltin_functions/
andbuiltin_interfaces/
tobuiltins/
.How I did it
rethinking of the approach; don't need two classes for each type, factor into VyperType + ExprInfo + VarInfo. handling of types in the regular namespace is generally by dispatching into special constructor (for structs and interfaces) or attributes (for enums) mode.
How to verify it
Commit message
Description for the changelog
Cute Animal Picture