feat: add convert for enum #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
- Coverage 88.16% 88.12% -0.04%
==========================================
Files 97 97
Lines 10820 10894 +74
Branches 2569 2580 +11
==========================================
+ Hits 9539 9600 +61
- Misses 823 838 +15
+ Partials 458 456 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
fubuloubu
approved these changes
Jul 23, 2022
docs/types.rst
Outdated
| @@ -622,5 +622,6 @@ All type conversions in Vyper must be made explicitly using the built-in ``conve | |||
| * Narrowing conversions (e.g., ``int256 -> int128``) check that the input is in bounds for the output type. | |||
| * Converting between bytes and int types results in sign-extension if the output type is signed. For instance, converting ``0xff`` (``bytes1``) to ``int8`` returns ``-1``. | |||
| * Converting between bytes and int types which have different sizes follows the rule of going through the closest integer type, first. For instance, ``bytes1 -> int16`` is like ``bytes1 -> int8 -> int16`` (signextend, then widen). ``uint8 -> bytes20`` is like ``uint8 -> uint160 -> bytes20`` (rotate left 12 bytes). | |||
| * Enums can be converted to ``uint256`` only. | |||
There was a problem hiding this comment.
What are the issues to converting to lesser values? Can't you determine the upper bound for a given Enum and throw a compiler or runtime error if it exceeds it?
There was a problem hiding this comment.
Since enums are uint256 under the hood, I don't think there are any issues with supporting conversion to smaller integer types. It is more of whether we want to support that conversion.
There was a problem hiding this comment.
@fubuloubu i think the whole range of ints is a bit harder to test; we can add them later too
charles-cooper
requested changes
Jul 25, 2022
charles-cooper
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
WIP
How I did it
WIP
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture