perf: remove compiler hotspots #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the changed lines triggered re-traversals of the entire AST, resulting in O(n^2) build times. for non-trivial contracts near the 24KB limit, this resulted in near-minute long build times.
charles-cooper
changed the title
charles-cooper
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2981 +/- ##
==========================================
- Coverage 88.09% 88.01% -0.09%
==========================================
Files 97 97
Lines 10852 10868 +16
Branches 2574 2572 -2
==========================================
+ Hits 9560 9565 +5
- Misses 832 844 +12
+ Partials 460 459 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
This pull request introduces 1 alert when merging 3612c7f into feb142b - view on LGTM.com new alerts:
|
fubuloubu
approved these changes
Jul 24, 2022
|
This pull request introduces 1 alert when merging efead2b into 6090953 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging bd3a4fb into 72bb12e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0aa4ea5 into 72bb12e - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
reduce build time.
time vyper Vault.vy went from
0m13.121sto0m3.521stime vyper CurveCryptoSwap2.vy went from
0m53.054sto0m5.259sHow I did it
investigating the time spent in various compiler phases, turns out 90% was spent in just three places.
the relevant lines triggered re-traversals of the entire AST, resulting
in O(n^2) build times. for non-trivial contracts near the 24KB limit,
this resulted in near-minute long build times.
this commit also adds timer utility functions so that the profiling can be easily done again.
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture