Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enum variables accessed via self. #2998

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jul 28, 2022

What I did

UX fix: enum members accessed directly with self would throw a compiler panic

How I did it

fix namespace detection in codegen

How to verify it

see tests

Commit message

enum members accessed directly with self would throw a compiler panic

Description for the changelog

Cute Animal Picture

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #2998 (ecbf3f2) into master (f31f0ec) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   88.29%   88.29%   -0.01%     
==========================================
  Files          97       97              
  Lines       10919    10933      +14     
  Branches     2583     2585       +2     
==========================================
+ Hits         9641     9653      +12     
- Misses        830      831       +1     
- Partials      448      449       +1     
Impacted Files Coverage Δ
vyper/codegen/expr.py 84.32% <100.00%> (-0.04%) ⬇️
vyper/builtin_functions/functions.py 90.28% <0.00%> (-0.12%) ⬇️
vyper/cli/vyper_compile.py 68.14% <0.00%> (ø)
vyper/compiler/__init__.py 88.09% <0.00%> (ø)
vyper/compiler/output.py 89.00% <0.00%> (+0.11%) ⬆️
vyper/compiler/phases.py 90.99% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@charles-cooper charles-cooper added this to the v0.3.5 milestone Jul 28, 2022
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a few more tests, but otherwise looking good

@charles-cooper
Copy link
Member Author

what kind of tests?

@fubuloubu
Copy link
Member

what kind of tests?

Maybe public, accessing inside an internal method, that sort of thing

@charles-cooper
Copy link
Member Author

@fubuloubu see 82e1d36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants