-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enum variables accessed via self.
#2998
fix: enum variables accessed via self.
#2998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 88.29% 88.29% -0.01%
==========================================
Files 97 97
Lines 10919 10933 +14
Branches 2583 2585 +2
==========================================
+ Hits 9641 9653 +12
- Misses 830 831 +1
- Partials 448 449 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a few more tests, but otherwise looking good
what kind of tests? |
Maybe public, accessing inside an internal method, that sort of thing |
@fubuloubu see 82e1d36 |
What I did
UX fix: enum members accessed directly with
self
would throw a compiler panicHow I did it
fix namespace detection in codegen
How to verify it
see tests
Commit message
enum members accessed directly with
self
would throw a compiler panicDescription for the changelog
Cute Animal Picture