Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty builtin in kwargs and constants #3008

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Jul 29, 2022

What I did

Fix #3004. Also fixes empty for constant.

How I did it

Add _kwargable attribute to Empty builtin.

How to verify it

See tests.

Commit message

fix: allow empty builtin in kwargs and constants

Description for the changelog

Allow empty builtin in kwargs and constants.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #3008 (3e33543) into master (f31f0ec) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #3008   +/-   ##
=======================================
  Coverage   88.29%   88.30%           
=======================================
  Files          97       97           
  Lines       10919    10926    +7     
  Branches     2583     2585    +2     
=======================================
+ Hits         9641     9648    +7     
  Misses        830      830           
  Partials      448      448           
Impacted Files Coverage Δ
vyper/semantics/types/utils.py 90.22% <83.33%> (+0.46%) ⬆️
vyper/builtin_functions/functions.py 90.41% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slept on it and i think _kwargable is a fine name for this (as in the terminology in vyper/semantics/types/utils.py, kwargable implies constant)

@charles-cooper
Copy link
Member

charles-cooper commented Jul 29, 2022

confirmed privately this PR is ready to come out of draft

@charles-cooper charles-cooper marked this pull request as ready for review July 29, 2022 14:39
@charles-cooper charles-cooper merged commit cb41608 into vyperlang:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot initialise default values for variable in fn args using empty
3 participants