Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): compile warnings #3033

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

delaaxe
Copy link
Contributor

@delaaxe delaaxe commented Aug 6, 2022

What I did

Fixed the compile warnings in examples

How I did it

:%s/ZERO_ADDRESS/empty(address)/g

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good besides one comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #3033 (b3ebc84) into master (7bcfed1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
- Coverage   88.34%   88.34%   -0.01%     
==========================================
  Files          97       97              
  Lines       10961    10963       +2     
  Branches     2589     2590       +1     
==========================================
+ Hits         9684     9685       +1     
- Misses        829      830       +1     
  Partials      448      448              
Impacted Files Coverage Δ
vyper/codegen/expr.py 85.23% <0.00%> (-0.18%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@delaaxe delaaxe force-pushed the fix/examples-warnings branch from 171fce6 to b3ebc84 Compare August 7, 2022 10:24
@delaaxe
Copy link
Contributor Author

delaaxe commented Aug 7, 2022

looks good besides one comment

thanks, fixed it

@charles-cooper charles-cooper merged commit 22ae74c into vyperlang:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants