feat: add epsilon builtin #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyper/builtin_functions/functions.py
Outdated
| # this check seems redundant, but sets a pattern to be followed | ||
| # when new decimal types are created | ||
| if isinstance(input_type, DecimalDefinition): | ||
| val = self._eval_decimal(input_type) |
There was a problem hiding this comment.
i think you can just inline _eval_decimal here. the use of that pattern elsewhere is to deal with some kind of inheritance, not needed here.
vyper/builtin_functions/functions.py
Outdated
| @@ -120,6 +121,22 @@ | |||
| SHA256_BASE_GAS = 60 | |||
| SHA256_PER_WORD_GAS = 12 | |||
|
|
|||
| class FoldedFunction(BuiltinFunction): | |||
| # Base class for nodes which should always be folded | |||
| _id = "" | |||
There was a problem hiding this comment.
probably can leave this out -- that way if the subclass does not supply _id, accessing the attribute will fail explicitly rather than silently
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
- Coverage 88.34% 86.88% -1.46%
==========================================
Files 97 97
Lines 10963 10965 +2
Branches 2590 2528 -62
==========================================
- Hits 9685 9527 -158
- Misses 830 964 +134
- Partials 448 474 +26
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
charles-cooper
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added an epsilon() builtin which returns the smallest non-zero value for a decimal type.
Closes #2992
How I did it
In
vyper/builtin_functions/functions.pyI implemented a new classEpsilon. The function that this class represents should always be folded.Instead of adding to the duplication between MinMaxValue and MethodID, I created a new base class
FoldedFunctionwhich contains all the logic for enforcing a function should always be folded.In
Epsilon'sevaluatefunction, we check the type that was passed in, ensure it is aFixedAbstractType(which is the parent class for Decimal and any other decimal classes to be supported later).Then we call the appropriate
_eval_<type>function after checking which type was passed in. This currently only supports "decimal" but sets up a pattern for adding support for other decimal types in the future.How to verify it
Run the new test, which checks a compiled contract's return value against a folded node.
Commit message
Implement
epsilonfor decimal typesDescription for the changelog
Cute Animal Picture